[buddypress-trac] [BuddyPress Trac] #8473: Unscoped bp_nouveau_ajax_querystring on single activity page is affecting other loops
buddypress-trac
noreply at wordpress.org
Wed May 12 12:22:44 UTC 2021
#8473: Unscoped bp_nouveau_ajax_querystring on single activity page is affecting
other loops
--------------------------+-----------------------------
Reporter: sbrajesh | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Core | Version: 7.3.0
Severity: normal | Keywords: has-patch
--------------------------+-----------------------------
Hi,
The function bp_nouveau_ajax_querystring which filters on
'bp_ajax_querystring' has a part of code like this
{{{
// Single activity.
if ( bp_is_single_activity() ) {
$qs = array(
'display_comments=threaded',
'show_hidden=true',
'include=' . bp_current_action(),
);
}
}}}
Since it does not check the $object for activity type, It is affecting all
other loops on the single activity page. I have a theme with sidebar for
single activity page and the members loop is getting
affected(include=activityid)
If we update the code and add test for object type, that will fix the
issue. Please find the patch attached.
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8473>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list