[buddypress-trac] [BuddyPress Trac] #8472: Incorrect Type check in Members generates extremely long SQL query

[buddypress-trac]

#8472: Incorrect Type check in Members generates extremely long SQL query
--------------------------+-----------------------------
 Reporter:  comminski     |      Owner:  (none)
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  REST API      |    Version:  7.3.0
 Severity:  normal        |   Keywords:
--------------------------+-----------------------------
 Hi, I reported issue #8299 last year and @imath was able to fix it. It was
 a SQL overheat issue which was fixed by checking if the search_terms
 argument was null and  setting it to false if no search term was passed.

 His fix is on github here:[https://github.com/buddypress/BP-
 REST/commit/e20475ef1fcfdae4aad34e7c71aec5072b194a21]

 The issue was happening in groups, but I noticed that the same problem
 also happens in the members page.

 I think the solution is to apply the same fix (which was applied on line
 141 of class-bp-rest-group-membership-endpoint.php) to line 125 of class-
 bp-rest-members-endpoint.php.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8472>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac