[buddypress-trac] [BuddyPress Trac] #8421: Migrate from Travis to GitHub Actions
buddypress-trac
noreply at wordpress.org
Sun May 2 17:11:43 UTC 2021
#8421: Migrate from Travis to GitHub Actions
------------------------------+-----------------------
Reporter: slaFFik | Owner: slaFFik
Type: task | Status: assigned
Priority: normal | Milestone: 8.0.0
Component: Build/Test Tools | Version:
Severity: normal | Resolution:
Keywords: has-patch |
------------------------------+-----------------------
Changes (by imath):
* keywords: 2nd-opinion needs-refresh => has-patch
Comment:
Hi @espellcaste
Thanks a lot for your great work on the patch 💪. It was failing at first
because of a wrong indentation around the `on` keyword. See
https://github.com/imath/buddypress/actions/runs/804600937
So
[https://buddypress.trac.wordpress.org/attachment/ticket/8421/8421.3.patch
8421.3.patch] is fixing it along with updating the patch with latest BP
Trunk. (Parcel was already updated to 1.12.5 in `package.json` and wp-
phpunit was > 5.7 in `composer.json`).
And it's working!
[[Image(https://cldup.com/_lPXBuwzJT.png)]]
So to apply the patch, here's my suggestion:
- remove the `composer.lock` file and `/vendor` directory, then run
`composer install`
- remove the `npm-shrinwrap.json` file and then run `npm install`.
I believe the PHPCS part needs to be more meaningful eg: testing
`buddypress` text domains or/and `/* translators: */ inline comments in
translation or/and testing PHP Compatibility for example. Otherwise let's
just remove these "Coding Standards" jobs.
I'm fine with committing the unit tests part the way it is 👍
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8421#comment:15>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list