[buddypress-trac] [BuddyPress Trac] #7228: Add PHPCS

[buddypress-trac]

#7228: Add PHPCS
------------------------------+-----------------------
 Reporter:  DJPaul            |       Owner:  (none)
     Type:  enhancement       |      Status:  reopened
 Priority:  normal            |   Milestone:  8.0.0
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:                    |
------------------------------+-----------------------

Comment (by espellcaste):

 That's interesting because the example given is one where I don't think a
 patch should be blocked from being sent/pushed/committed.

 It's also important to remember that PHPCS doesn't check for code styling
 and rules only. There are several levels of severity for errors and
 warnings and we should strive to not allow errors with severity of 1.
 Those are the ones that should be blocked from being patched/sent.

 If your code has a level 1 severity error, that's something that we should
 not be committing to the project, regardless if you are a new contributor
 or a seasoned one.

 Today, there is no guardrail for that. Anyone can push whatever they want
 and there is no indication of problematic code being commited to the
 project. No only of bugs but also of code styling or standards. Even from
 an awareness point of view: there is nothing. Literally a wild west!

 Here we are relying on the contributors and on the code reviewers, which
 are error proned since those are humans, to ensure code quality. But
 again, those are error proned, however how talent or smart they are, or
 think they are.

 We can do better and PHPCS is one sensible step in that direction. :)

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7228#comment:19>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac