[buddypress-trac] [BuddyPress Trac] #8437: 'bp_core_avatar_default' filter is used twice, but for different purposes

buddypress-trac noreply at wordpress.org
Tue Feb 16 22:03:31 UTC 2021


#8437: 'bp_core_avatar_default' filter is used twice, but for different purposes
--------------------------+------------------------------
 Reporter:  r-a-y         |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Core          |     Version:  2.6.0
 Severity:  normal        |  Resolution:
 Keywords:  dev-feedback  |
--------------------------+------------------------------
Description changed by r-a-y:

Old description:

> In r10688, the `'bp_core_avatar_default'` filter was introduced for a
> second time, but is used for a different purpose. That filter is used in
> the generation of the Gravatar URL. We should rename this filter because
> it is causing a conflict when the real `'bp_core_avatar_default'`
> parameter is used. Perhaps rename the filter to
> `'bp_core_avatar_gravatar_default'`?
>
> The `'bp_core_avatar_default'` filter was actually introduced back in
> BuddyPress 2.0 in r7769.

New description:

 In r10688, the `'bp_core_avatar_default'` filter was introduced for a
 second time, but is used for a different purpose (see #6989). That filter
 is used in the generation of the Gravatar URL. We should rename this
 filter because it is causing a conflict when the real
 `'bp_core_avatar_default'` filter is used. Perhaps rename the filter to
 `'bp_core_avatar_gravatar_default'`?

 The `'bp_core_avatar_default'` filter was actually introduced back in
 BuddyPress 2.0 in r7769.

--

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8437#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list