[buddypress-trac] [BuddyPress Trac] #8001: Review at.js integration for updates and/or swapout

buddypress-trac noreply at wordpress.org
Fri Feb 12 19:08:28 UTC 2021

#8001: Review at.js integration for updates and/or swapout
 Reporter:  boonebgorges             |       Owner:  (none)
     Type:  task                     |      Status:  new
 Priority:  normal                   |   Milestone:  8.0.0
Component:  Core                     |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  needs-testing has-patch  |

Comment (by imath):

 @dcavins I've just tested your patch. It works! Thanks a lot for your work
 on it.

 8001.03.patch]​ I'm suggesting some improvements:
 1. Let's use sass to generate the mention.css style and let's improve the
 style so that it looks closer than what we had so far 😉
 2. Let's avoid some jQuery deprecated stuff ( `$(document).ready()` and
 `$.isArray` )
 3. Let's avoid arrow functions ( `users => cb( users )` ) or if we want to
 use Modern JS, let's do it completely 😁
 4. There was a Tribute warning, so I've added some code to only attach
 Tribute when not already attached to an input.

 In Nouveau it's a bit annoying we can't have the autocomplete to work into
 the WP Editor as it's currently working with At.js. I haven't tried to add
 it yet, but I believe we should try.

 I also believe we can still improve it trying to avoid the current user to
 be into the autocomplete.

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8001#comment:13>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list