[buddypress-trac] [BuddyPress Trac] #8474: The WordPress Full Site Editing feature & BuddyPress

[buddypress-trac]

#8474: The WordPress Full Site Editing feature & BuddyPress
--------------------------+---------------------
 Reporter:  imath         |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  high          |   Milestone:  10.0.0
Component:  Core          |     Version:
 Severity:  critical      |  Resolution:
 Keywords:  has-patch     |
--------------------------+---------------------

Comment (by oztaser):

 I've worked on the issue about group avatar.

 1. I'm using GNU\Linux and `wp-env` docker environment.
 1. I disabled object cache and all other plugins.

 Here are what I've found:
 * Avatar upload screen is working well when group is creating.
 * The issue occurs on `/groups/example-group/admin/group-avatar/` page.
 * My user is the only administrator of the group and I can change the
 group cover image.
 * It looks like change avatar template is not loading. I don't even see
 the `Change Group Avatar` title in page source.
 * I've compared how the page template loads on Twenty Twenty One and
 Twenty Twenty Two. Somehow Twenty Twenty Two can't run the action
 `bp_after_group_admin_content` [ 1 ]
 * To fix this I've created the patch below. After this patch screen
 template is loading as I expected.

 I don't know if this is a good solution or a real issue, but these are my
 test results.

 {{{
 diff --git a/src/bp-templates/bp-nouveau/includes/groups/functions.php
 b/src/bp-templates/bp-nouveau/includes/groups/functions.php
 index f87d873af..9b49d248f 100644
 --- a/src/bp-templates/bp-nouveau/includes/groups/functions.php
 +++ b/src/bp-templates/bp-nouveau/includes/groups/functions.php
 @@ -1211,7 +1211,7 @@ function bp_nouveau_group_get_core_manage_screens(
 $id = '' ) {
         $screens = array(
                 'edit-details'        => array( 'hook' =>
 'group_details_admin',             'nonce' => 'groups_edit_group_details'
 ),
                 'group-settings'      => array( 'hook' =>
 'group_settings_admin',            'nonce' => 'groups_edit_group_settings'
 ),
 -               'group-avatar'        => array(),
 +               'group-avatar'        => array( 'hook' =>
 'group_settings_avatar',           'nonce' => ''
 ),
                 'group-cover-image'   => array( 'hook' =>
 'group_settings_cover_image',      'nonce' => ''
 ),
                 'manage-members'      => array( 'hook' =>
 'group_manage_members_admin',      'nonce' => ''
 ),
                 'membership-requests' => array( 'hook' =>
 'group_membership_requests_admin', 'nonce' => ''
 ),
 }}}

 [ 1 ] https://github.com/buddypress/buddypress/blob/master/src/bp-core/bp-
 core-cssjs.php#L206

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8474#comment:9>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac