[buddypress-trac] [BuddyPress Trac] #8558: Adapt Group extensions registration to BP Rewrites

[buddypress-trac]

#8558: Adapt Group extensions registration to BP Rewrites
--------------------------+---------------------
 Reporter:  imath         |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  10.0.0
Component:  Groups        |     Version:  1.1
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+---------------------

Comment (by imath):

 Hi @boonebgorges,

 Thanks a lot for your feedback and the tests you did with some of your
 plugins with BP Rewrites.

 About moving Group extensions registration down to `bp_parse_query`: I
 must admit I'm considering it because it seems the easiest way ☺️ for BP
 Rewrites.

 But, I'm fine with leaving the Group Extension registration to happen at
 `bp_init`. I'll start checking each method of the `BP_Group_Extension` API
 first to see if they are trying to get something that can't be set with BP
 Rewrites on. For example the `get_group_id()` method shouldn't be used
 before `bp_parse_query` (the origin of the issue reported by @shanebp),
 and at the same time I can understand the need to adapt the Group
 Extension behavior according to the displayed Group, so I think we should
 provide guidances/new methods/functions to do that once the Group can be
 set.

 Our goal is to make this change without breaking any plugins (there might
 be a few exceptions, e.g. when no tests were made about these few plugins
 with the BP Rewrites one).

 BP Rewrites won't be merged in BP 10.0.0 or even in 11.0.0, I believe. The
 goal is to release a stable version of BP Rewrites on the WP.org plugins
 directory to ease testing. And take the needed time, from there, to test
 as much BuddyPress plugins as possible. We'll improve the BP Rewrites
 plugin often and **until** we reach the required level of confidence we
 need to do the big switch to the WP Rewrite API safely into BuddyPress
 core.

 We still have a quite long road 😅.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8558#comment:2>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac