[buddypress-trac] [BuddyPress Trac] #6749: bp_get_group_avatar() needs to work outside the loop

buddypress-trac noreply at wordpress.org
Sat Aug 21 14:42:16 UTC 2021


#6749: bp_get_group_avatar() needs to work outside the loop
-------------------------------------------------+-------------------------
 Reporter:  slaFFik                              |       Owner:
                                                 |  espellcaste
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  10.0.0
Component:  Groups                               |     Version:  1.0
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests dev-        |
  reviewed                                       |
-------------------------------------------------+-------------------------
Changes (by imath):

 * keywords:  has-patch has-unit-tests => has-patch has-unit-tests dev-
     reviewed


Comment:

 Hi @espellcaste

 Thanks a lot for your work on this second patch. It looks nice, you'll
 find some suggestions mainly about DocBlocks into the patch I suggest to
 use to compliment yours below.

 NB: the patch also fixes an issue with how you edited
 `bp_get_group_avatar()`: the `html` argument needs to default to `true`
 otherwise the avatar image is not output, and we get instead the avatar
 URL (which can be retrieved using `bp_get_group_avatar_url()`.

 Once you've fixed the `bp_get_group_avatar()` issue and If you're
 confident with the patch, feel free to commit it.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6749#comment:11>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list