[buddypress-trac] [BuddyPress Trac] #8139: Network Invitations and Membership Requests

[buddypress-trac]

#8139: Network Invitations and Membership Requests
--------------------------+-----------------------
 Reporter:  dcavins       |       Owner:  (none)
     Type:  enhancement   |      Status:  assigned
 Priority:  normal        |   Milestone:  8.0.0
Component:  Registration  |     Version:  5.0.0
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+-----------------------

Comment (by dcavins):

 Thanks again for your feedback.

 The email salutation is set in bp_email_get_salutation(). If we don't want
 to show the email address, it looks like we'll have to change the logic
 there or add a filter on that hook to replace the salutation with just
 "Hi".

 Thank you for solving the opt-out message display. Your answer is perfect,
 and I didn't realize that wp_die() could do that, though it seems obvious
 now.

 Thanks also for fixing the warning in `bp_email_set_default_headers()`. I
 had to rejigger some things to make nonmember unsubscribe links work
 better yesterday and missed that piece.

 Regarding who should be notified when a user accepts an invitation. I am
 of two minds about this. If two users invite the same person, the new user
 will have had to accept the invitation via the link in one of the emails.
 So I decided that the followed link should determine which invitation was
 primarily accepted, and that inviter is used in the activity item and
 receives a notification. The other invitations are marked as accepted, but
 do not receive notifications. I can see the notification part both ways.
 One possibility is that we could send a notification to the other inviters
 that the person is now a member of the site, so they can go friend them or
 introduce themselves.

 Yep, the notification needs to be marked "read" when they follow the link.
 That's on my to-do list.

 I'll see what the test is failing about.

 I agree with all of your improvement suggestions, though I thought the
 "you are already a member" when attempting to follow an accepted invite
 was already in there at one point.

 Your last point about not keeping the invitations after opt-out is also
 true and will be simple to implement.

 Thanks!

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8139#comment:50>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac