[buddypress-trac] [BuddyPress Trac] #8139: Network Invitations and Membership Requests

[buddypress-trac]

#8139: Network Invitations and Membership Requests
--------------------------+-----------------------
 Reporter:  dcavins       |       Owner:  (none)
     Type:  enhancement   |      Status:  assigned
 Priority:  normal        |   Milestone:  8.0.0
Component:  Registration  |     Version:  5.0.0
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+-----------------------

Comment (by imath):

 Hi @dcavins !

 We're even closer 😉 Here's the result of my tests on a fresh WP trunk
 install:
 - I confirm the Invitation Email has a subject ✅
 - I really don't like the salutation "
 - I confirm the un-subscriptions are handled ✅
 - I confirm it's not possible to invite a user who has opted out, or an
 existing user ✅
 - I had a notice error about a missing 'member_id' argument into
 `bp_email_set_default_headers()` 😬.
 - The screen notification is cool 👍
 - *But* The invite screen notification is not "sent" to all inviters if
 the user was invited by more than one member. (I haven't checked the
 invitations table to see if all invites are updated as accepted for the
 email, but if not I believe it should).
 - *But* When you click on WP Admin Bar bubble link, it's not cleared from
 the active notifications. User needs to go to the member's notifications
 screen to mark it as read.
 - Watch out:
 `BP_Tests_Invitations::test_bp_invitations_add_invitation_avoid_duplicates`
 is still failing since .05.patch 😉.

 About the success feedback when a user unsubscribed. Let's start with a
 `wp_die()` There's only one thing we need to know in this case: are we out
 of it!

 __Possible improvements:__
 1. I believe the error message when sending an invite fails should be
 improved: "There was a problem sending that invitation. Possible reasons
 are: this email is the one of an existing member, or the user has opted
 out from being invited to this site, you have no luck!")
 2. I clicked on an invite link, registered and then clicked again on the
 invite link and I can reach the registration form again. I believe we
 should at least check the email when an invitation link has been clicked
 and at the very least add an error, eg: "you are already a member of the
 site, please login. If you forgot your password, go this way {link to wp-
 login/lostpassword action}".
 3. When I click again on an unsubscribe link, the feedback message should
 be different. I can imagine some anxious people clicking more than once on
 this link, so telling them "Hey we got you the first time, you don't need
 to unsubscribe again, you already are!" will make them happy.

 __Very important improvement, I even think it's a blocker:__
 When users opt out **we can't keep usable data about them**, that's why we
 are hashing their emails. So as soon as a user opt outs, the corresponding
 invitation data **must** be erased. I was able to resend an invitation
 from the regular member's pending invite screen as well as being an admin
 from the Invitation Management screen. Not even the admin can do that.

 PS: I haven't reviewed the code this time.

 8139.06.companion.patch is fixing the PHP notice and suggests to use the
 `wp_die()` way to confirm the user unsubscribed.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8139#comment:49>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac