[buddypress-trac] [BuddyPress Trac] #8139: Network Invitations and Membership Requests

[buddypress-trac]

#8139: Network Invitations and Membership Requests
--------------------------+-----------------------
 Reporter:  dcavins       |       Owner:  (none)
     Type:  enhancement   |      Status:  assigned
 Priority:  normal        |   Milestone:  8.0.0
Component:  Registration  |     Version:  5.0.0
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+-----------------------

Comment (by imath):

 Hi @dcavins, thanks a lot for your progress about the feature: we're
 getting close!

 -
 [https://buddypress.trac.wordpress.org/attachment/ticket/8139/8139.05.refreshed.patch
 8139.05.refreshed.patch] is a refreshed version of your patch to take in
 account the latest commit I did recently.
 -
 [https://buddypress.trac.wordpress.org/attachment/ticket/8139/8139.05.review.patch
 8139.05.review.patch] contains my recommandations and more integration
 with BP Nouveau

 Here's some explanations about my recommandations (the
 `8139.05.review.patch` suggests fixes):
 - There's a PHP 8.0 deprecated usage of a required parameter after an
 optional one in `BP_Members_Invitation_Manager->run_acceptance_action()`.
 - The BuddyPress tools sub menu is not highlighted when viewing the
 Invitations Management screen.
 - The BP_Members_Invitations_List_Table views and action links were still
 using the `users.php` base url (instead of `tools.php`).
 - I hope we'll fix this ticket before BP `78.0.0`! There was some inline
 comment typos like this.
 - I also saw some WP code formatting issues and I've added some escaping
 functions at various places.
 - wp_doing_ajax() was introduced in WP 4.7, let's use it!
 - I've added the JavaScript & CSS parts for the member's Pending invites
 front-end screen: the PHP part still needs to be done.

 [[Image(https://cldup.com/oNfo7c334D.png)]]

 About the tests I did:
 - The email subject is empty a BP Email invite is sent.
 - The email invitation unsubscribe link doesn't seem to be handled yet.
 - I believe it would be better to say "Hi Name" instead of "Hi email" into
 the email salutation.
 - A failing test appeared in
 `BP_Tests_Invitations::test_bp_invitations_add_invitation_avoid_duplicates`
 since .05.patch.
 - The super admin cannot view another member's Invitations front-end
 pages, is this on purpose? If so, maybe the navigations shouldn't be
 displayed for him.

 I'm confident you'll be able to have it ready soon. Keep up the good work!

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8139#comment:42>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac