[buddypress-trac] [BuddyPress Trac] #6347: XProfile fields used for signup should be configurable

[buddypress-trac]

#6347: XProfile fields used for signup should be configurable
------------------------------+------------------------------
 Reporter:  johnjamesjacoby   |       Owner:  johnjamesjacoby
     Type:  enhancement       |      Status:  reopened
 Priority:  high              |   Milestone:  8.0.0
Component:  Extended Profile  |     Version:  1.0
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |
------------------------------+------------------------------
Changes (by imath):

 * keywords:  has-patch => has-patch commit


Comment:

 [https://buddypress.trac.wordpress.org/attachment/ticket/6347/6347.alt.2.patch
 6347.alt.2.patch] improves 6347.alt.patch by taking in charge the previous
 points I sill had to work on:

 - ~~I still need to improve it to select all Base group fields if signup
 are enabled.~~
 - ~~I still need to add a filter if the user has overriden the register
 template to improve backcompat.~~
 - ~~I still need to improve the JavaScript UI because when you drag a
 field into the Signup fields tab, as it's not removing the dragged field
 from the original Groups tab, the group fields can be sorted differently
 (moving the dragged field at the top).~~
 - ~~I still need to add a metabox into the field's edit screen to enjoy
 previously added code for the signup_position metabox to remove a field
 from the signup form from this screen.~~

 About the last point, it also handles adding a field to the signup form
 from the xProfile field edit screen. The position in this case defaults to
 the last one.

 I also added the `signup_position` to the Field Type supported features
 introduced in [12868]. This way a field type can disable the signup
 position metabox.
 Finally I've improved the JavaScript UI to dynamically add/remove the
 `(Sign-up)` span if a field was added/removed using Ajax.

 I believe it's ready to be committed. I'll run some complementary tests
 before doing so early next week, unless someone has an objection about it
 ;)

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6347#comment:33>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac