[buddypress-trac] [BuddyPress Trac] #8360: inconsistent table checks in notifications

[buddypress-trac]

#8360: inconsistent table checks in notifications
-------------------------------------+------------------------------
 Reporter:  shawfactor               |       Owner:  johnjamesjacoby
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  7.0.0
Component:  Core                     |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |
-------------------------------------+------------------------------
Changes (by shawfactor):

 * keywords:  reporter-feedback has-patch needs-testing => has-patch needs-
     testing


Comment:

 Guys the current behaviour is hugely problematic for my startup as we are
 trying to build a SAAS solution with shared tables for all components
 except xprofile, but maintaining different buddypress pages on each site.

 WE have achieved this by setting BP_ENABLE_MULTIBLOG, using the
 buddypress-multi-network plugin, and filtering most tables to be
 "global_tables". However $bp->core table_name is not filtered so some
 functionality simply does not work. eg setting notifications to read
 (using bp_notifications_mark_notification) uses
 $bp->core->table_name_notification in check_access and
 buddypress()->notifications->table_name to actually update the
 notification (and hence does not work).

 if there is a way of overririding this until buddypress 7.0 I´d be
 appreciative if you could let me know.

 In terms of the future I would advocate for a consistent approach that
 does not handle backwards compatability as that would minimise technical
 debt.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8360#comment:8>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac