[buddypress-trac] [BuddyPress Trac] #8360: inconsistent table checks in notifications
buddypress-trac
noreply at wordpress.org
Fri Sep 11 17:57:15 UTC 2020
#8360: inconsistent table checks in notifications
-------------------------------+----------------------------------
Reporter: shawfactor | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: Under Consideration
Component: Core | Version:
Severity: normal | Resolution:
Keywords: reporter-feedback |
-------------------------------+----------------------------------
Comment (by johnjamesjacoby):
A quick search for `$bp->core->` brings up 12 results, and all of them
should probably be updated.
It is probably safe by now to simply remove this old code, but I never
like the idea of totally obliterating backwards compatibility. Ya just
never know.
To maintain back-compat, I can imagine adding a magic getter to `BP_Core`
that reroutes touches to `table_name_notifications` to use
`buddypress()->notifications->table_name` instead. That way everything
uses the same thing.
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8360#comment:3>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list