[buddypress-trac] [BuddyPress Trac] #8355: Site Admins cannot edit BP emails

[buddypress-trac]

#8355: Site Admins cannot edit BP emails
-----------------------------------+---------------------
 Reporter:  shanebp                |       Owner:  DJPaul
     Type:  defect (bug)           |      Status:  new
 Priority:  normal                 |   Milestone:  7.0.0
Component:  Emails                 |     Version:  6.2.0
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |
-----------------------------------+---------------------

Comment (by johnjamesjacoby):

 Remember that there is no guarantee that the `administrator` role exists,
 as well as its `capabilities` array key. I would add some `isset()` checks
 to avoid unintentionally invoking a role that wasn’t there previously.

 `_bp_enforce_bp_moderate_cap_for_admins()` makes a similar assumption,
 which is not ideal but apparently hasn’t been an issue for anyone yet. It
 doesn’t really seem right, but I don’t have a better idea right now.

 The idea with `bp_moderate` was that it replaced all of the
 `is_super_admin()` calls, so it is intentional for it to be a higher than
 normal type of privilege. If it’s not mapping correctly, is it possible
 that WordPress core is checking the incorrect capability in this location?

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8355#comment:12>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac