[buddypress-trac] [BuddyPress Trac] #8292: Multiple member types users table issue
buddypress-trac
noreply at wordpress.org
Thu Oct 22 23:34:11 UTC 2020
#8292: Multiple member types users table issue
--------------------------+---------------------
Reporter: etatus | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: 7.0.0
Component: Members | Version: 5.2.0
Severity: major | Resolution:
Keywords: has-patch |
--------------------------+---------------------
Changes (by imath):
* keywords: has-patch needs-refresh => has-patch
Comment:
@vapvarun thanks a lot for the improvements you brought to your patch. To
be consistent with how setting group types is managed, I believe we should
allow to pass an array to the `bp_set_member_type()` function.
[https://buddypress.trac.wordpress.org/attachment/ticket/8292/8292.2.patch
8292.2.patch] is doing so. The patch is also making sure bulk
adding/removing a member type functionality is more consistent with what
we should expect: remove all member types when the remove bulk action was
used (instead of one of the member type) and replace all member types with
the selected member type for the add/set bulk action.
About this last point, I believe we should edit the bulk adding/removing a
group type the same way in another ticket.
Unit tests are doing ok. Could you test the patch to confirm it behaves
the right way?
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8292#comment:10>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list