[buddypress-trac] [BuddyPress Trac] #8305: Add regular delete confirmation screen for XProfile field groups

buddypress-trac noreply at wordpress.org
Tue May 26 14:15:42 UTC 2020


#8305: Add regular delete confirmation screen for XProfile field groups
----------------------------+----------------------
 Reporter:  oztaser         |       Owner:  slaFFik
     Type:  enhancement     |      Status:  new
 Priority:  normal          |   Milestone:  7.0.0
Component:  Administration  |     Version:  2.3.0
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |
----------------------------+----------------------

Comment (by imath):

 Hi @oztaser

 I just had a look at your patch and I've tested it. It's a very
 interesting work. Thanks a lot.

 1. Suggestion:

 {{{
 // Let's use strict comparison at line 90 like:
 in_array( $mode, array( 'delete_group', 'do_delete_group' ), true )
 }}}

 2. The Base group is required and not deletable
 Into the edit group page, you should only include the delete link if the
 edited group is not the Base one.

 3. What about confirming fields deletion?
 I'm wondering if we should also add this confirmation step for fields.
 Would it be too annoying at usage?

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8305#comment:5>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list