[buddypress-trac] [BuddyPress Trac] #8304: Add `Delete Permanently` link to activity edit page
buddypress-trac
noreply at wordpress.org
Sun May 24 14:50:38 UTC 2020
#8304: Add `Delete Permanently` link to activity edit page
----------------------------+----------------------
Reporter: oztaser | Owner: slaFFik
Type: enhancement | Status: new
Priority: normal | Milestone: 7.0.0
Component: Administration | Version: 1.6
Severity: normal | Resolution:
Keywords: has-patch |
----------------------------+----------------------
Comment (by oztaser):
> 1) Could you include 8304-2b.patch to your patch: it removes the
javascript:confirm from the delete action of the Activity WP List Table
that is no more necessary.
Nice catch, I added your update to my patch.
> 2) Instead of the content or the activity action, I think it would be
better to use something like this for the bullet points of the
confirmation page: "Action/type" activity submitted by username on date
with a link to the activity on the date.
Thanks for the advice, I was not sure about this. Everything is clear now.
I've also updated the code style based on your suggestions. Thanks again
for the review, I hope it's ready to commit.
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8304#comment:6>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list