[buddypress-trac] [BuddyPress Trac] #8304: Add `Delete Permanently` link to activity edit page

buddypress-trac noreply at wordpress.org
Sat May 23 08:49:53 UTC 2020


#8304: Add `Delete Permanently` link to activity edit page
-----------------------------------------+----------------------
 Reporter:  oztaser                      |       Owner:  slaFFik
     Type:  enhancement                  |      Status:  new
 Priority:  normal                       |   Milestone:  7.0.0
Component:  Administration               |     Version:  1.6
 Severity:  normal                       |  Resolution:
 Keywords:  has-patch reporter-feedback  |
-----------------------------------------+----------------------
Changes (by imath):

 * keywords:   => has-patch reporter-feedback
 * owner:  (none) => slaFFik
 * version:   => 1.6
 * component:  Activity => Administration
 * milestone:  Awaiting Review => 7.0.0


Comment:

 Hi @oztaser

 Thanks a lot for your ticket and for your patch. I agree we should add
 this delete link to the activity edit page. But something bothers me: the
 javascript confirm as we are using a regular confirmation screen when
 deleting group or signup. I believe we should try to do the same thing
 everywhere : use a regular confirmation screen.

 Here's the Group's delete confirmation screen:
 https://buddypress.trac.wordpress.org/browser/trunk/src/bp-groups/bp-
 groups-admin.php#L688
 Here's the Signup action confirmation screen:
 https://buddypress.trac.wordpress.org/browser/trunk/src/bp-members/classes
 /class-bp-members-admin.php#L2147

 Could you update your patch into this direction?

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8304#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list