[buddypress-trac] [BuddyPress Trac] #8299: Incorrect Type check in Groups generates extremely long SQL query

[buddypress-trac]

#8299: Incorrect Type check in Groups generates extremely long SQL query
-------------------------------+------------------------------
 Reporter:  comminski          |       Owner:  (none)
     Type:  defect (bug)       |      Status:  new
 Priority:  normal             |   Milestone:  Awaiting Review
Component:  Groups             |     Version:  5.2.0
 Severity:  normal             |  Resolution:
 Keywords:  reporter-feedback  |
-------------------------------+------------------------------

Comment (by comminski):

 Hi, thank you for looking into this, here is more detail on how to
 reproduce this:

 - I am using the Nouveau template
 - BuddyPress 5.1.2 (upgraded to 6.0.0 and experienced the same issue)
 - WordPress version 5.4.1
 - WordPress Theme: Twenty Nineteen
 - Tested in Chrome 81.0 & Firefox 75.0
 - BuddyPress was the only active plugin on the site

 I created a new Private group called `Test`
 I added `var_dump($search_terms); die();` to line 400 of `buddypress/bp-
 core/classes/class-bp-user-query.php`
 I visited the manage-members area at wordpress.lcl/groups/test/admin
 /manage-members/
 I found $search_terms was null, not false

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8299#comment:3>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac