[buddypress-trac] [BuddyPress Trac] #8299: Incorrect Type check in Groups generates extremely long SQL query

[buddypress-trac]

#8299: Incorrect Type check in Groups generates extremely long SQL query
--------------------------+-----------------------------
 Reporter:  comminski     |      Owner:  (none)
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Groups        |    Version:  5.2.0
 Severity:  normal        |   Keywords:
--------------------------+-----------------------------
 If you have a site with a large group of users and you go to A BP Group
 and select Manage > Members, it triggers a sql query to return the list of
 members

 On line 402 of buddypress/bp-core/classes/class-bp-user-query.php, there
 is a boolean check `false !== $search_terms`. For this query,
 $search_terms is `null`, not False, so the SQL query generates a `AND u.ID
 IN` statement with every user_id in the database.

 This is causing an issue on WP Engine where the query can be so long, that
 it is Killed.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8299>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac