[buddypress-trac] [BuddyPress Trac] #7729: Remove BuddyBar?

buddypress-trac noreply at wordpress.org
Tue Mar 3 03:49:02 UTC 2020


#7729: Remove BuddyBar?
--------------------------------------+---------------------
 Reporter:  DJPaul                    |       Owner:  (none)
     Type:  enhancement               |      Status:  new
 Priority:  normal                    |   Milestone:  6.0.0
Component:  Navigation                |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch needs-dev-note  |
--------------------------------------+---------------------
Changes (by imath):

 * keywords:  has-patch => has-patch needs-dev-note


Comment:

 Hi @r-a-y

 Thanks for the refresh, I just tested the patch and I'm having a doubt
 about line 596 of  `src/bp-groups/classes/class-bp-groups-component.php`.
 In your patch you're removing it, but then we get a failing test:
 `BP_Tests_Core_Nav_BpCoreNewNavItem::test_group_nav()`.

 I've been tested the patch with or without this line and it doesn't seem
 to have an impact. But I'd probably keep it this way, just in case.

 If you're sure we don't need it anymore, then remove the
 `BP_Tests_Core_Nav_BpCoreNewNavItem::test_group_nav()` test ;)

 I believe we probably need to write a dev note about this removal on
 bpdevel 🤔

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7729#comment:17>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list