[buddypress-trac] [BuddyPress Trac] #8336: Cover Image Cannot be Uploaded on Windows Server using the REST endpoint

[buddypress-trac]

#8336: Cover Image Cannot be Uploaded on Windows Server using the REST endpoint
-------------------------+--------------------------
 Reporter:  oddev56      |       Owner:  espellcaste
     Type:  enhancement  |      Status:  assigned
 Priority:  normal       |   Milestone:  7.0.0
Component:  REST API     |     Version:  6.1.0
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |
-------------------------+--------------------------

Comment (by oddev56):

 Replying to [comment:1 espellcaste]:
 > @oddev56 Thank you for raising that. I created a pull request in the
 REST API repo with the fix: https://github.com/buddypress/BP-REST/pull/348
 >
 > Would you be willing to test that pull request and see if it works in
 your Windows environment?  Since I don't have a Windows environment setup.
 >
 > Otherwise, will try to see if someone in the team has a Windows
 environment setup to test/confirm the patch/update.

 Hello @espellcaste , thanks for the quick response!.

 You missed the change to the condition, it should check if it equals (===)
 1. So (0 !==) should be changed to (1 ===).

 I can't test the pull request, but can assure you that i made that change
 and tested it on my Windows Server and it works correctly, as the previous
 patch to this issue on the non REST part.

 I'm currently working on a project that will be released soon and needs
 this feature to let users change their cover image, it would be great if
 this fix could be integrated into the next BuddyPress update, so i won't
 have to instruct my clients to make this change manually.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8336#comment:2>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac