[buddypress-trac] [BuddyPress Trac] #8236: `empty()` check for activity content after kses filtering

[buddypress-trac]

#8236: `empty()` check for activity content after kses filtering
--------------------------+---------------------
 Reporter:  oztaser       |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  6.0.0
Component:  Activity      |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+---------------------
Changes (by imath):

 * keywords:   => has-patch
 * milestone:  Awaiting Review => 6.0.0


Comment:

 Hi! This is shaping great, I think I would do the check a bit later, just
 after the statement about component and type:

 {{{
 if ( empty( $this->component ) || empty( $this->type ) )
 }}}

 This way you are sure about the fact type is not empty before checking
 it’s not `activity_update`.

 Thanks a lot for your work on it 👌

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8236#comment:5>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac