[buddypress-trac] [BuddyPress Trac] #7076: I18n: make XProfile admin js text nodes translatable
buddypress-trac
noreply at wordpress.org
Mon Dec 21 04:37:02 UTC 2020
#7076: I18n: make XProfile admin js text nodes translatable
------------------------------+-----------------------
Reporter: Offereins | Owner: slaFFik
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 8.0.0
Component: I18N | Version:
Severity: normal | Resolution:
Keywords: has-patch commit |
------------------------------+-----------------------
Changes (by imath):
* keywords: has-patch => has-patch commit
* milestone: 7.1.0 => 8.0.0
Comment:
Hi @slaFFik
Patch looks good. Thanks for your work on it. I'd just suggest to align
the array items according to WPCS, this way:
{{{
'default_value' => __( 'Default Value', 'buddypress' ),
'delete' => __( 'Delete', 'buddypress' ),
}}}
We'll include this fix into 8.0.0 as it's not a regression from 7.0.0.
Feel free to commit it in trunk 👍
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7076#comment:5>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list