[buddypress-trac] [BuddyPress Trac] #8163: WP 5.3 use of the spread operator, our PHP required version (5.3) & BP_Walker_Nav_Menu

[buddypress-trac]

#8163: WP 5.3 use of the spread operator, our PHP required version (5.3) &
BP_Walker_Nav_Menu
--------------------------+-----------------------------------
 Reporter:  imath         |      Owner:  (none)
     Type:  defect (bug)  |     Status:  new
 Priority:  high          |  Milestone:  5.1.0
Component:  Core          |    Version:  1.7
 Severity:  major         |   Keywords:  has-patch 2nd-opinion
--------------------------+-----------------------------------
 For the context, WordPress introduced the usage of the spread operator
 `...` in various. As we don't use internally the `BP_Walker_Nav_Menu` nor
 `bp_nav_menu()` we haven't seen we were concerned by this evolution.
 @johnjamesjacoby committed [12497] to fix the problem in trunk (here and
 on the plugins SVN repo) using this spread operator. As a result Unit
 Tests are failing when PHP is 5.3.

 We had some discussions on Slack about whether we should increase our PHP
 required version to 5.6 for our next major version.

 I believe (after a good night of sleep), as WordPress 5.3 has been
 released and even if the use of `BP_Walker_Nav_Menu` or `bp_nav_menu()`
 might be an edge case, we should fix this issue in 5.1.0.

 @timothybjacobs shared the way WPCLI faced this trouble on our
 [https://wordpress.slack.com/archives/C02RQBYUG/p1573613526424100 Slack
 channel] (many thanks to him). So I suggest we use a similar way.

 See attached patch.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8163>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac