[buddypress-trac] [BuddyPress Trac] #8097: RTL stylesheets must replace with regular ones, not extend them
buddypress-trac
noreply at wordpress.org
Fri May 24 20:43:42 UTC 2019
#8097: RTL stylesheets must replace with regular ones, not extend them
-------------------------------------------------+-------------------------
Reporter: geminorum | Owner: (none)
Type: defect (bug) | Status: new
Priority: high | Milestone: 5.0.0
Component: Core | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-refresh reporter- |
feedback |
-------------------------------------------------+-------------------------
Changes (by imath):
* keywords: has-patch => has-patch needs-refresh reporter-feedback
* milestone: Awaiting Review => 5.0.0
Comment:
Hi @geminorum
Thanks a lot for your ticket and for your patch. Instead of defining a
`$rtl` variable to eventually use the rtl version instead of the ltr, I
think it can be achieved using `'replace'` instead of `true` for the last
arguments of `wp_style_add_data()`.
For instance :
{{{
wp_style_add_data( 'bp_activity_admin_css', 'rtl', 'replace' );
}}}
Could you check if it's the case and if so, update the patch accordingly ?
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8097#comment:2>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list