[buddypress-trac] [BuddyPress Trac] #6210: Create New Invitations API
buddypress-trac
noreply at wordpress.org
Tue Mar 19 18:45:06 UTC 2019
#6210: Create New Invitations API
-----------------------------------------+-----------------------
Reporter: dcavins | Owner: dcavins
Type: enhancement | Status: reopened
Priority: low | Milestone:
Component: Core | Version:
Severity: normal | Resolution:
Keywords: dev-feedback trac-tidy-2018 |
-----------------------------------------+-----------------------
Comment (by boonebgorges):
> I'm not sure that adding a special cache group
bp_groups_invitations_for_user is needed, given that invitations are
individually cached, and the SQL query results are cached using an
incrementor.
IMHO, it's needed just for clarity's sake. The driving force behind this
ticket is that requests and invitations are NOT like memberships - they're
a different kind of entity. You're now storing them separately in the
database; you have different representations for them in the codebase (the
new `BP_Invitation` classes); you have different query methods; and so on.
Naively, this suggests that we shouldn't be forcing them into the same
cache group either, especially since doing so requires us to concatenate
keys, etc.
For backward compatibility, you do have to continue to pretend that
they're the same thing in the context of `bp_get_user_groups()`. But, for
ease of comprehension, we should minimize this.
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6210#comment:37>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list