[buddypress-trac] [BuddyPress Trac] #6210: Create New Invitations API
buddypress-trac
noreply at wordpress.org
Thu Mar 14 21:06:19 UTC 2019
#6210: Create New Invitations API
-----------------------------------------+-----------------------
Reporter: dcavins | Owner: dcavins
Type: enhancement | Status: reopened
Priority: low | Milestone:
Component: Core | Version:
Severity: normal | Resolution:
Keywords: dev-feedback trac-tidy-2018 |
-----------------------------------------+-----------------------
Comment (by boonebgorges):
Thanks for your work here, @dcavins ! These changes seem good to me.
The `class_name` trick looks fine. I prefer it to the `name`/`action`
juggling from your previous patch. One small thing I'd mention is that,
since you're silently translating the class name using `sanitize_key()` at
the time that the invite is saved, you may also want to do the same thing
to the 'class' parameter when *querying* for invitations. This way, if
someone naively tries passing in something like
`HardG\MyPlugin\InvitationManager`, the query will work.
What's the plan for the `bp_get_user_groups()` breaks? I haven't looked
into the root cause.
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6210#comment:29>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list