[buddypress-trac] [BuddyPress Trac] #8043: Convert XProfile admin AJAX to REST API

buddypress-trac noreply at wordpress.org
Wed Mar 13 17:56:12 UTC 2019

#8043: Convert XProfile admin AJAX to REST API
 Reporter:  boonebgorges      |       Owner:  (none)
     Type:  defect (bug)      |      Status:  closed
 Priority:  normal            |   Milestone:
Component:  Extended Profile  |     Version:
 Severity:  normal            |  Resolution:  wontfix
 Keywords:  needs-patch       |
Changes (by boonebgorges):

 * status:  new => closed
 * resolution:   => wontfix
 * milestone:  5.0.0 =>


 I've done some in-depth review of the existing AJAX here, and I don't know
 that there are any easy wins. Most of the interface does not, in fact, use
 AJAX. The only places where AJAX is actually used are as follows:

 1. Updating field order within a group. But this doesn't neatly fit with
 the REST endpoints - we need a bulk action. Probably best kept as a custom
 AJAX endpoint for now.
 2. Updating option order within a field. Same argument as 1.
 3. There's JS and PHP that's meant to power AJAX deletion of profile field
 groups, but it's broken in a couple of fundamental ways: there's no
 'confirm' message (as there is designed to be), there's no success/failure
 when performed asynchronously, and there's no `preventDefault()`, so the
 delete always takes place via a page refresh anyway. This could use
 fixing, but it's difficult to pick apart in this context.

 As such, I'm rescinding my initial suggestion that this is a "good first
 candidate" :) Moving to the REST API would be part of a more substantial

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8043#comment:3>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list