[buddypress-trac] [BuddyPress Trac] #6210: Create New Invitations API

buddypress-trac noreply at wordpress.org
Thu Mar 7 23:13:13 UTC 2019


#6210: Create New Invitations API
-----------------------------------------+-----------------------
 Reporter:  dcavins                      |       Owner:  dcavins
     Type:  enhancement                  |      Status:  reopened
 Priority:  low                          |   Milestone:
Component:  Core                         |     Version:
 Severity:  normal                       |  Resolution:
 Keywords:  dev-feedback trac-tidy-2018  |
-----------------------------------------+-----------------------
Changes (by dcavins):

 * keywords:  dev-feedback, trac-tidy-2018 => dev-feedback trac-tidy-2018
 * status:  closed => reopened
 * resolution:  maybelater =>


Comment:

 I've written a new patch for this and updated group invitations to use the
 new logic. It went better than I expected, though there are still some
 question marks, because group memmberships and invitations are so
 intertwined currently.

 I was able to update nearly all phpunit tests to verify that existing
 group invitation behavior works as expected. (The failing tests show that
 `bp_get_user_groups()` is going to be a sticking point.)

 I'd appreciate feedback on the core setup (introducing a
 `BP_Invitiations_Invitations` class that represents an invitation and
 contains the SQL-query-building logic, a base logic class `BP_Invitations`
 that is meant to be extended to adapt the behavior to specific components,
 and an extension class `BP_Groups_Invitations` to handle the management
 for group invitations).

 If the basic structure makes sense, I'll work on writing the network and
 site invitation extension classes, which seem pretty doable.

 Thanks for your feedback!

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6210#comment:24>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list