[buddypress-trac] [BuddyPress Trac] #6210: Create New Invitations API

buddypress-trac noreply at wordpress.org
Wed Jul 31 22:14:26 UTC 2019

#6210: Create New Invitations API
 Reporter:  dcavins                     |       Owner:  dcavins
     Type:  enhancement                 |      Status:  reopened
 Priority:  low                         |   Milestone:  5.0.0
Component:  Core                        |     Version:
 Severity:  normal                      |  Resolution:
 Keywords:  dev-feedback needs-refresh  |

Comment (by dcavins):

 Hi @imath-

 Thanks for your comments. Other than the notifications comment, I've
 integrated your suggestions into the most recent patch.

 In the most recent patch, I also updated many tests that were adding
 "unconfirmed" users to the `groups_members` table directly, so were not
 fully testing the somewhat complicated code that adds invitations table
 info to the `BP_Group_Member_Query` results.

 >What if a plugin is checking the Group members table for is_confirmed = 0
 or invites_sent = 1 ? I can imagine it's difficult to manage, do you plan
 to write a dev note (on bpdevel for instance) to anticipate/inform about
 this new & great API?

 Yes, direct checks of the `groups_members` table will no longer yield the
 right answers. Similarly, manipulating the `BP_Groups_Member` object
 directly will no longer work (though it never triggered the necessary
 hooks, so never really "worked"). Hopefully, most devs have been using
 `BP_Group_Member_Query` and/or the invitation/request related functions
 instead of direct table lookups. I will write up a how-to on updating code
 to avoid deprecation errors and such.

 Regarding the notifications comment, I doubt they ever were removed (since
 the delete/reject hooks are all still in place, and any removal would have
 been tied to those hooks), but this seems like a good time to update that
 behavior. I haven't worked with notifications for a while, so I'll have to
 remember how to find the appropriate notifications to delete.

 Thanks again for the thorough review and feedback!

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6210#comment:48>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list