[buddypress-trac] [BuddyPress Trac] #6210: Create New Invitations API

[buddypress-trac]

#6210: Create New Invitations API
----------------------------------------+-----------------------
 Reporter:  dcavins                     |       Owner:  dcavins
     Type:  enhancement                 |      Status:  reopened
 Priority:  low                         |   Milestone:  5.0.0
Component:  Core                        |     Version:
 Severity:  normal                      |  Resolution:
 Keywords:  dev-feedback needs-refresh  |
----------------------------------------+-----------------------

Comment (by imath):

 Thanks a lot for your work on it. You're almost arrived at the finish
 line! Congrats 💪

 I confirm points 1, 3 and 4 of
 [https://buddypress.trac.wordpress.org/ticket/6210#comment:42 comment #42]
 are fixed.
 Point 2 is being dealt in [https://github.com/buddypress/BP-REST/pull/197
 PR #197]

 About point 5, it's actually a bug we currently have! But let's fix it
 here 😁: Could you edit line 797 of `src/bp-groups/classes/class-bp-
 groups-component.php` replacing `if ( ! empty( $count['total'] ) ) {` by
 `if ( $count ) {`

 Here are some last advices/concerns:

 - When a group invite is removed for a user the corresponding notification
 is not.
 - About `bp_groups_migrate_invitations()` I'm a little worried if there
 are a lot of group invites, pending requests to migrate : is there a risk
 of time out ?
 - The code in `src/bp-core/bp-core-invitations-cache.php` could be added
 to `src/bp-core/bp-core-cache.php` that would avoid to add/load a new file
 for only one function, If you apply this then don't forget to remove the
 include part in `class-buddypress.php` ☺️
 - in `src/bp-core/classes/class-bp-invitation.php` there are extra line
 feeds at line 2, 89 & 135
 - in `src/bp-core/classes/class-bp-invitation-manager.php` there's an
 extra line feed at line 562
 - What if a plugin is checking the Group members table for `is_confirmed =
 0` or `invites_sent = 1` ? I can imagine it's difficult to manage, do you
 plan to write a dev note (on bpdevel for instance) to anticipate/inform
 about this new & great API?

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6210#comment:47>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac