[buddypress-trac] [BuddyPress Trac] #8031: Messages - Alert icon is shown twice which is not intuitive.
buddypress-trac
noreply at wordpress.org
Thu Jan 10 20:41:28 UTC 2019
#8031: Messages - Alert icon is shown twice which is not intuitive.
--------------------------+------------------------------
Reporter: pooja1210 | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Core | Version: 4.1.0
Severity: normal | Resolution:
Keywords: |
--------------------------+------------------------------
Comment (by boonebgorges):
Hi @pooja1210 - Thanks for the report!
@imath - Quick question for you when you have a moment. This is happening
because `displayFeedback()` is being given a string containing multiple
`bp-feedback` divs. In an ideal world, I'd think that you should be able
to pass multiple (separate) messages to `displayFeedback`, and it'd then
build *separate* bp-feedback items. But this might be hard to make work
(it'd complicate the process of clearing feedback, for example). So maybe
we could just modify the value passed to `displayFeedback` in this case so
that it's a `ul` of errors instead? See screenshot and patch. Obviously,
we'd clean up the spacing :)
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8031#comment:2>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list