[buddypress-trac] [BuddyPress Trac] #8035: Nouveau: AJAX filter in Friends Requests returns incorrect and incorrectly-formatted results

buddypress-trac noreply at wordpress.org
Thu Jan 10 19:57:43 UTC 2019


#8035: Nouveau: AJAX filter in Friends Requests returns incorrect and incorrectly-
formatted results
-------------------------------------------------+-------------------------
 Reporter:  oxibug                               |       Owner:
                                                 |  boonebgorges
     Type:  defect (bug)                         |      Status:  closed
 Priority:  normal                               |   Milestone:  5.0.0
Component:  Friends                              |     Version:  3.0.0
 Severity:  major                                |  Resolution:  fixed
 Keywords:  dev-feedback has-screenshots has-    |
  patch                                          |
-------------------------------------------------+-------------------------
Changes (by boonebgorges):

 * owner:  (none) => boonebgorges
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"12322" 12322]:
 {{{
 #!CommitTicketReference repository="" revision="12322"
 Nouveau: Fixes for the Friends Request page.

 The Friends Request page was introduced in Nouveau with the same dropdown
 filter as on other member directories, but the functionality was never
 fully implemented. In this changeset, we make the following changes:

 * Ensure that the AJAX request distinguishes between friend request
 queries and other membership queries, so that the members returned are
 limited to friend requests.
 * Break the friend request loop logic into its own template, so that the
 outer template information (title, pagination, etc) doesn't appear twice
 after an AJAX filter.
 * Modify the logic in the friend-request template so that it uses
 `bp_ajax_querystring()`, which lets the filters affect the returned
 results.

 Props imath.
 Fixes #8035.
 }}}

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8035#comment:8>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list