[buddypress-trac] [BuddyPress Trac] #7935: bp_core_new_nav_default() not working since v3.0.0

[buddypress-trac]

#7935: bp_core_new_nav_default() not working since v3.0.0
--------------------------+---------------------
 Reporter:  r-a-y         |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  3.3.0
Component:  Core          |     Version:  3.0.0
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+---------------------

Comment (by r-a-y):

 > I'd probably won't use 'id' but 'component_id' as it won't be unique for
 each nav items so it seems a bit confusing to me.

 We have a second function argument called `$component` in
 `bp_core_new_nav_default()`, so I didn't initially want to name the new
 parameter `$args['component_id']` because it might be confusing.

 But, @imath, you're right that `'id'` also is too vague.  `04.patch`
 changes the parameter to `'component_id'`.  Anyone else have anything to
 add before committing?

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7935#comment:10>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac