[buddypress-trac] [BuddyPress Trac] #7935: bp_core_new_nav_default() not working since v3.0.0
buddypress-trac
noreply at wordpress.org
Tue Sep 11 17:03:02 UTC 2018
#7935: bp_core_new_nav_default() not working since v3.0.0
--------------------------+---------------------
Reporter: r-a-y | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: 3.3.0
Component: Core | Version: 3.0.0
Severity: normal | Resolution:
Keywords: has-patch |
--------------------------+---------------------
Comment (by r-a-y):
> Shouldn't it be 'item_css_id' instead of 'link_css_id' ?
@imath - Good catch, again. I shouldn't code at night! :) I've updated
`02.patch.
> What about adding a new component_id parameter to nav functions and make
the slug and css_id parameters fall back to it ?
I like this idea. Instead of making the ID fall back to `slug` or
`css_id`, I left it empty. See `03.patch`. I'm setting the ID in `class-
bp-component.php`, so the ID should always be set for most developers
extending the `BP_Component` class. A minor thing is if a plugin is
overriding the `setup_nav` method, but this isn't really a big deal since
this ticket is only dealing with core components requiring their screen
function code.
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7935#comment:8>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list