[buddypress-trac] [BuddyPress Trac] #7935: bp_core_new_nav_default() not working since v3.0.0

[buddypress-trac]

#7935: bp_core_new_nav_default() not working since v3.0.0
--------------------------+---------------------
 Reporter:  r-a-y         |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  3.3.0
Component:  Core          |     Version:  3.0.0
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+---------------------

Comment (by r-a-y):

 > I'm just wondering if $parent_nav->slug is always the same than the
 component ID. I'm thinking about the xProfile component in particular.

 @imath - Good catch.  I've made two changes:

 1. For the path, I'm now using `$bp->core->path` because we're only
 concerned with the BuddyPress core path anyway.
 2. Due to the fact that the slugs can be modified by a developer, I'm now
 using `$parent_slug->css_id` since that uses the component ID for the most
 part - https://buddypress.trac.wordpress.org/browser/tags/3.1.0/src/bp-
 core/bp-core-buddybar.php?marks=139-141,147#L113.  XProfile component sets
 `link_css_id` as the component ID -
 https://buddypress.trac.wordpress.org/browser/tags/3.1.0/src/bp-
 xprofile/classes/class-bp-xprofile-component.php?marks=257#L235.

 It might make sense to set the `link_css_id` for all components to the
 component ID just to be safe.  For example, for the Settings component, we
 would add the `link_css_id` parameter directly after this line -
 https://buddypress.trac.wordpress.org/browser/tags/3.1.0/src/bp-
 settings/classes/class-bp-settings-component.php?marks=146#L124

 Let me know what you think.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7935#comment:6>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac