[buddypress-trac] [BuddyPress Trac] #7853: Register page in Trunk is showing %s with username, password etc

[buddypress-trac]

#7853: Register page in Trunk is showing %s with username, password etc
--------------------------+-----------------------------
 Reporter:  sbrajesh      |      Owner:  (none)
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Templates     |    Version:  3.0.0
 Severity:  normal        |   Keywords:
--------------------------+-----------------------------
 I am running current trunk. The register form is showing %s literal with
 the username/password etc on the register page.

 The problem lies with the mismatching of the number of type placeholders
 in the format string and the number of args to the sprintf.

 There are two possible solutions

 1. Remove the format directives from the labels in
 "bp_nouveau_get_signup_fields()"

 2. Or revert back to what we had in 3.0 (I believe the change was
 intentional and  should not be reverted, instead option 1 should be used)
 in "bp_nouveau_signup_form".

 The change that triggered it is in


 {{{
         // Text fields are using strings, radios are using their inputs
                 $label_output = '<label for="%1$s">%2$s</label>';
 }}}

 changed to


 {{{
                 if ( $required ) {
                         /* translators: Do not translate placeholders. 2 =
 form field name, 3 = "(required)". */
                         $label_output = __( '<label for="%1$s">%2$s
 %3$s</label>', 'buddypress' );
                 }

 }}}

 For required fields.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7853>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac