[buddypress-trac] [BuddyPress Trac] #7837: Group Detail Pages Not Showing w/ Custom Meta Plug-Ins in Version 3.0.0

[buddypress-trac]

#7837: Group Detail Pages Not Showing w/ Custom Meta Plug-Ins in Version 3.0.0
--------------------------+-----------------------
 Reporter:  gcmaryland    |       Owner:  r-a-y
     Type:  defect (bug)  |      Status:  accepted
 Priority:  normal        |   Milestone:  3.0.1
Component:  Templates     |     Version:  3.0.0
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+-----------------------
Changes (by r-a-y):

 * keywords:   => has-patch
 * status:  reviewing => accepted


Comment:

 The problem is Nouveau is missing the
 `'groups_custom_group_fields_editable'` hook, which quite a few plugins
 rely on to add their group meta markup.

 I have two approaches to fix this.

 `01.patch` is the straightforward approach.  `02.patch` is structured more
 within the Nouveau way of doing things, however `02.patch` also moves the
 "Notify members via email" checkbox to the
 `bp_nouveau_group_manage_screen()` function.  This is due to how the
 `'groups_custom_group_fields_editable'` hook needs to fire before the
 checkbox to match `bp-legacy`.  However, the
 `bp_nouveau_group_manage_screen()` function already contains some markup
 for nonces and submit button, so maybe this is okay?  We could add the
 checkbox markup to a hook if that is cleaner.

 Would like to have some feedback from @hnla and @imath.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7837#comment:3>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac