[buddypress-trac] [BuddyPress Trac] #7833: BP Nouveau: do not check the user exists when Accepting/rejecting friendships
buddypress-trac
noreply at wordpress.org
Wed May 16 08:46:39 UTC 2018
#7833: BP Nouveau: do not check the user exists when Accepting/rejecting
friendships
--------------------------+------------------------------
Reporter: imath | Owner: imath
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 3.0
Component: Templates | Version:
Severity: major | Keywords: has-patch commit
--------------------------+------------------------------
To avoid repeating various checks, i've grouped all friendship ajax
actions into a unique handler. But there are two cases where one of the
checks shouldn't be done: when accepting or rejecting a friendship, the
{{{$_POST['item_id']}}} is not a user ID but a friendship ID. So as soon
as we have more friendships than users Nouveau doesn't perform these two
actions because the user does not exists!
My bad & sorry for noticing it late! The attached patch is restricting the
user exists check to all other actions. I'll commit it before Midnight ;)
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7833>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list