[buddypress-trac] [BuddyPress Trac] #7822: Nouveau: Settings > Email menu item not visible

buddypress-trac noreply at wordpress.org
Fri May 11 18:11:49 UTC 2018


#7822: Nouveau: Settings > Email menu item not visible
--------------------------+---------------------
 Reporter:  boonebgorges  |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  highest       |   Milestone:  3.0
Component:  Settings      |     Version:
 Severity:  blocker       |  Resolution:
 Keywords:  has-patch     |
--------------------------+---------------------
Changes (by boonebgorges):

 * keywords:   => has-patch


Comment:

 Turns out this has nothing to do with Nouveau. It's a result of the
 screen-function loading changes from @r-a-y. Those changes moved the
 `bp_notification_settings` callbacks into their own conditionally-loaded
 files. But this meant that `bp_notification_settings` had no hooked
 functions, and as a result, `bp_settings_remove_email_subnav()` was doing
 its thing.

 The fix should just be to move the functions back out into a place where
 they're always loaded. I've chosen bp-*-notifications.php. Seem OK? @r-a-y
 Would be good to get your eyes on before commit. [attachment:7822.diff]

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7822#comment:8>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list