[buddypress-trac] [BuddyPress Trac] #7794: BP Nouveau: Backbone views tasks

buddypress-trac noreply at wordpress.org
Wed May 9 12:03:32 UTC 2018


#7794: BP Nouveau: Backbone views tasks
-----------------------+---------------------
 Reporter:  imath      |       Owner:  (none)
     Type:  task       |      Status:  new
 Priority:  normal     |   Milestone:  3.0
Component:  Templates  |     Version:
 Severity:  normal     |  Resolution:
 Keywords:  has-patch  |
-----------------------+---------------------
Changes (by mercime):

 * keywords:  needs-patch => has-patch


Comment:

 Replying to [comment:15 imath]:
 > @mercime 7794-removeInviteTooltip.patch is adding a Tooltip to explain
 that clicking on the avatar removes the user from the invites list.
 Thanks for the explanation about the tooltip @imath. [Attached ]
 - Added `aria-label` attr to the link and made the `alt` value = empty on
 the image so screen readers will announce the label and not have to repeat
 the username from the old image `alt` value.
 - Changed `'Remove %s from the invites'` from tooltip because it could
 grow very wide with the full name to shorter `'Disinvite %s'` which is
 more consistent with the invite/disinvite from Invite Members screen.
 - Style changes include: improve positioning of bp-tooltip for the UI, add
 cleafix and 100% width to UL containing participants' profile photos, add
 top margin for `#bp-send-invites-form`.

 Replying to [comment:16 hnla]:
 > overflow would hide the tooltip, it was appropriate before we started to
 change things, now you'll need to use  the clearfix class or mixin
 provided to ensure float containment if still necessary.
 Implemented clearfix on `.buddypress .bp-invites-content #send-invites-
 editor ul`

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7794#comment:19>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list