[buddypress-trac] [BuddyPress Trac] #7731: BP Nouveau: Messages UI issues
buddypress-trac
noreply at wordpress.org
Wed May 9 08:57:43 UTC 2018
#7731: BP Nouveau: Messages UI issues
--------------------------+---------------------
Reporter: mercime | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: 3.0
Component: Templates | Version:
Severity: blocker | Resolution:
Keywords: has-patch |
--------------------------+---------------------
Comment (by mercime):
@imath Tested the 7731.04.patch. Have similar results to 7731.03.patch:
passed on keyboard but not on screen readers except Chromevox/Chrome.
Replying to [comment:13 imath]:
> ... using a link for the message subject making sure this link doesn’t
make the Preview box useless.
Thinking about this, perhaps instead of making the Message Title link go
to view the full message screen, make that link navigate to a new anchor
link below -> Active Message (instead of Active Conversation) after the
list of Messages for all: mouse, keyboard, and screen reader users.
Whether we go on this route or not, please remove the `tabindex=0` on the
`.thread-item` because when focused, the screen reader announces the whole
row with the checkbox, link, and message link. Pressing Enter after
hearing any of those does not lead anywhere.
If we do go with suggestion above,
-- remove
`<span class="bp-screen-reader-text"><?php esc_html_e( 'Press Enter to
read the mesage below.', 'buddypress' ); ?></span>`
from bp-nouveau/buddypress/common/js-templates/messages/index.php as it is
no longer necessary to announce a link that works as expected.
-- change
`'howto' => __( 'Click on the message title to preview it in the
Active conversation box. Double click on the message title to open the
full conversation.', 'buddypress' ), `
to
`'howto' => __( 'Press Enter or click on the message title to read
it in the Active Message box below.', 'buddypress' ),`
It's almost a couple of hours past midnight so do excuse any mistakes made
above.
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7731#comment:18>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list