[buddypress-trac] [BuddyPress Trac] #7714: BP-Nouveau: Keyboard focus lost in air with Messages bulk actions UI

buddypress-trac noreply at wordpress.org
Sat Mar 31 13:27:41 UTC 2018


#7714: BP-Nouveau: Keyboard focus lost in air with Messages bulk actions UI
---------------------------------------+---------------------
 Reporter:  mercime                    |       Owner:  (none)
     Type:  defect (bug)               |      Status:  new
 Priority:  normal                     |   Milestone:  3.0
Component:  Templates                  |     Version:
 Severity:  normal                     |  Resolution:
 Keywords:  has-screenshots has-patch  |
---------------------------------------+---------------------

Comment (by hnla):

 @mercime yep like the additional enhancements & in addition perhaps would
 quite like to remove the initial border wrapping the hidden select/action
 popup when shown, this  is for two reasons #1 it removes the slight page
 jump to accommodate the element inline ( border adds height ) and #2
 having the element(s) show without border gives a more text like visual
 style that fits better with your text addition 'All Messages', also on
 hover of the select we do have a border appear to help define this as a
 select element visually ( which could be increased in strength/color)


 {{{
 .buddypress-wrap .subnav-filters .user-messages-bulk-actions .bulk-
 actions-wrap {
     border: 1px solid #eee;
 }
 }}}

 Other than that I do have a major concern over the input elements being
 used without a form parent and where they don't need strictly to be inputs
 ( as you mention earlier) if we are only passing data to scripts ( a bad
 thing but...) not sure what we can do about this though at this stage.

 Ignoring the above input concern lets bash this in, the focus is important
 the enhancements good and if we can pull out the border style above I'm
 happy :)

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7714#comment:9>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list