[buddypress-trac] [BuddyPress Trac] #6921: Maybe introduce PHP Mustache parser for email templates
buddypress-trac
noreply at wordpress.org
Thu Mar 22 13:47:35 UTC 2018
#6921: Maybe introduce PHP Mustache parser for email templates
----------------------------+-----------------------
Reporter: Paul Gibbs | Owner: (none)
Type: enhancement | Status: reopened
Priority: normal | Milestone: Up Next
Component: Emails | Version: 2.5.0
Severity: normal | Resolution:
Keywords: trac-tidy-2018 |
----------------------------+-----------------------
Comment (by Paul Gibbs):
I've done a partial refresh of the old patch, just to get something on the
table. It is not tested at all, might even have typos.
Looking at the old original patch, the `bp_is_user_active()` change, as
well as the tweak in `bp_email_set_default_tokens()`, seem unnecessary to
be mixed in with this patch. We should just not send email to a spammed
user? (not sure if handle that already or not) Either way, not in scope
for this ticket. So I left it out.
On the token replacement, we need to check if the library supports
callable values for tokens, otherwise we need to resolve those first.
We might also want to consider caching the compiled templates in object
cache (I am concerned about these getting too large, but if they're only a
few KB, it's acceptable. I don't know if caching these would help from a
performance perspective enough to be worth the trade-off).
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6921#comment:7>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list