[buddypress-trac] [BuddyPress Trac] #7875: BP Nouveau - Group Invites UI, the optional inviter message is never sent to invited users

buddypress-trac noreply at wordpress.org
Fri Jun 29 10:21:38 UTC 2018


#7875: BP Nouveau - Group Invites UI, the optional inviter message is never sent
to invited users
--------------------------+---------------------
 Reporter:  imath         |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  4.0
Component:  Templates     |     Version:  3.0.0
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |
--------------------------+---------------------
Changes (by DJPaul):

 * keywords:  has-patch 2nd-opinion => needs-patch
 * milestone:  Awaiting Review => 4.0


Comment:

 The idea is fine, the patch needs some work because changing the function
 signature like this can be dangerous. I don't think you can type-hint the
 first parameter, and you need to handle that possibly being passed a
 string for backwards compatibility (in case someone is calling the
 function manually, or has hooked it somewhere else, etc).

 (On commit, change the modified `since` version to 4.0.)

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7875#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list