[buddypress-trac] [BuddyPress Trac] #7905: Upload photos broken in older bp-default themes

[buddypress-trac]

#7905: Upload photos broken in older bp-default themes
--------------------------+-----------------------
 Reporter:  r-a-y         |      Owner:  (none)
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  3.2.0
Component:  Core          |    Version:  3.0.0
 Severity:  normal        |   Keywords:  has-patch
--------------------------+-----------------------
 On new installations, `bp-nouveau` is the default template pack.

 However, for themes still using a version of `bp-default`, attempting to
 upload a photo results in a fatal error:


 {{{
 PHP Fatal error:  Uncaught Error: Call to undefined function
 bp_nouveau_user_feedback() in \wp-content\plugins\buddypress\bp-templates
 \bp-nouveau\buddypress\assets\_attachments\avatars\index.php:38
 Stack trace:
 #0 \wp-includes\template.php(690): require()
 #1 \wp-content\plugins\buddypress\bp-core\bp-core-template-
 loader.php(155): load_template('..', false)
 #2 \wp-content\plugins\buddypress\bp-core\bp-core-template-loader.php(61):
 bp_locate_template(Array, true, false)
 #3 \wp-content\plugins\buddypress\bp-core\bp-core-attachments.php(993):
 bp_get_template_part('assets/_attachm...')
 #4 \wp-content\plugins\buddypress\bp-core\bp-core-avatars.php(2025):
 bp_attachments_get_template_part('avatars/index')
 #5 \wp-includes\class-wp-hook.php(286): bp_avatar_template_check('')
 #6 \wp-includes\class-wp in \wp-content\plugins\buddypress\bp-templates
 \bp-nouveau\buddypress\assets\_attachments\avatars\index.php on line 38
 }}}

 There are three ways to address this:

 1) Ask bp-default theme developers to add `add_theme_support( 'buddypress-
 use-legacy' )` to their `functions.php`, but this requires theme
 developers to patch their themes.

 2) Patch up `bp-nouveau` to work with bp-default themes.  Don't know how
 much work this will be.

 3) Patch up `bp_attachments_get_template_part()` to call on bp-legacy if
 the theme is using an older bp-default theme.

 I opted for option 3, but can I get some feedback from @imath about this?

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7905>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac