[buddypress-trac] [BuddyPress Trac] #7866: Privacy: Privacy policy integration into registration process

[buddypress-trac]

#7866: Privacy: Privacy policy integration into registration process
--------------------------+---------------------
 Reporter:  boonebgorges  |       Owner:  (none)
     Type:  enhancement   |      Status:  new
 Priority:  normal        |   Milestone:  4.0
Component:  Core          |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  2nd-opinion   |
--------------------------+---------------------

Comment (by boonebgorges):

 @imath Thanks for the review!

 [attachment:Screenshot_2018-06-19_09-54-27.png] shows (roughly) what your
 `bp_nouveau_get_signup_fields()` looks like. IMHO, it's not great: the
 placement of the checkbox seems bad to me, and I don't like how this
 "acceptance" is tied together with the Account Details section, rather
 than broken out into its own area. In most signup processes around the
 web, I've observed that this type of confirmation is usually put just
 before the Submit button, and I think it's worth a template edit to
 maintain that convention here.

 > Then if I understand right, the problem is for template pack !=
 ´nouveau’ so instead of adding an hidden field to see if the check needs
 to be done i’d probably create a filterable function that checks 'nouveau'
 === bp_get_theme_package_id() to do the policy acceptance require check in
 bp_core_screen_signup().

 It's not just template_pack != 'nouveau'. First, some people may already
 have forked the template in their own (Nouveau-powered) theme, so relying
 on 'nouveau' would break registrations as soon as they update to 4.0.
 Second, I don't like tying this too closely to Nouveau, as it should be a
 part of all future (or custom) template packs. A clunky, but foolproof,
 way to check would be to load the registration template into an output
 buffer and look for the `signup-privacy-policy-accept` checkbox.

 > Finally, I would advise to provide some « easy to put in place » for a
 site administrator back compat for legacy and default

 Yes, great point. When we decide how it'll work in Nouveau, I'll write a
 drop-in that devs can add to their own themes.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7866#comment:8>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac